Skip to content

fix(2.0): niche cases for DCE#2161

Open
lxsmnsyc wants to merge 4 commits into
mainfrom
fix-2160
Open

fix(2.0): niche cases for DCE#2161
lxsmnsyc wants to merge 4 commits into
mainfrom
fix-2160

Conversation

@lxsmnsyc

@lxsmnsyc lxsmnsyc commented Jun 19, 2026

Copy link
Copy Markdown
Member

Fixes #2160
Fixes #2168

@changeset-bot

changeset-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 02cb296

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Jun 19, 2026

Copy link
Copy Markdown

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 02cb296
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6a416b2e65ea9000085c84b8
😎 Deploy Preview https://deploy-preview-2161--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Jun 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2161
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2161

commit: 02cb296

@katywings

Copy link
Copy Markdown
Contributor

Lovely fixes <3. Thank you @lxsmnsyc. I am adding a couple tests in a few moments.

@lxsmnsyc

Copy link
Copy Markdown
Member Author

Added a change.

Moved the directives compiler step before Solid's so that the compiler's aggressive DCE can run first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug?]: "invalid server function" when having a server function without a router [Bug?]: Compiler Error for some unused variables

2 participants